Remove that the Ruler WAL is a coming soon feature #10732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on what we have written here: https://grafana.com/docs/loki/latest/operations/recording-rules/#write-ahead-log-wal A WAL for the Loki Ruler already has been implemented, so lets no longer leave it as a "future improvement"
github-actions
bot
added
the
type/docs
|
Can someone from the Loki team please confirm I'm correct in my understanding that this feature does already exist? If so, then we can merge this PR. |
JStickler
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
[docs team] LGTM
I did a little GitHub research:
The Docs for WAL were introduced in this January 2021 PR #3026
This "few things coming" line about WAL was introduced six months later (June 2021) PR #3851
The Recording rules topic was created in this (November 2021) PR #4566, I'm assuming that was what the "few things coming" line was referencing.
grafanabot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Based on what we have written here: https://grafana.com/docs/loki/latest/operations/recording-rules/#write-ahead-log-wal A WAL for the Loki Ruler already has been implemented, so lets no longer leave it as a "future improvement" (cherry picked from commit e78941f)
JStickler
pushed a commit
that referenced
this pull request
Sep 28, 2023
…10744) Backport e78941f from #10732 --- Based on what we have written here: https://grafana.com/docs/loki/latest/operations/recording-rules/#write-ahead-log-wal A WAL for the Loki Ruler already has been implemented, so lets no longer leave it as a "future improvement" Co-authored-by: Jennifer Villa <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Based on what we have written here: https://grafana.com/docs/loki/latest/operations/recording-rules/#write-ahead-log-wal A WAL for the Loki Ruler already has been implemented, so lets no longer leave it as a "future improvement"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on what we have written here:
https://grafana.com/docs/loki/latest/operations/recording-rules/#write-ahead-log-wal
A WAL for the Loki Ruler already has been implemented, so lets no longer leave it as a "future improvement"