indexshipper/storage: fix race conditions #10314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
reviewed
Aug 23, 2023
There was a problem hiding this comment.
LGTM. Do you also want to add a changelog entry?
@sandeepsukhani you might also wanna have a look.
Google's 'singleflight' package is much neater and makes all the race warnings go away.
|
Rebased and added a changelog entry. |
bboreham
force-pushed
the
cached-client-race
branch
from
f220164
to
7343290
Compare
chaudum
pushed a commit
that referenced
this pull request
Sep 14, 2023
There were many race conditions reported if you run `go test -race` on this package. Google's 'singleflight' package is much neater and makes all the race warnings go away. **Which issue(s) this PR fixes**: Relates to #8586
chaudum
added a commit
that referenced
this pull request
Sep 14, 2023
There were many race conditions reported if you run `go test -race` on this package. Google's 'singleflight' package is much neater and makes all the race warnings go away. **Which issue(s) this PR fixes**: Relates to #8586 **Special notes for your reviewer**: This is a backport of #10314 to the 2.9.x release branch. --------- Signed-off-by: Christian Haudum <[email protected]> Co-authored-by: Bryan Boreham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There were many race conditions reported if you run
go test -raceon this package.Google's 'singleflight' package is much neater and makes all the race warnings go away.
Which issue(s) this PR fixes:
Relates to #8586
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR