-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gateway client): exit with nil pointer dereference panic when using ring mode #13436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
Hello @chaudum!
Please, if the current pull request addresses a bug fix, label it with the |
1 similar comment
Hello @chaudum!
Please, if the current pull request addresses a bug fix, label it with the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-13436-to-k210 origin/k210
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 304db100b382f0c1d1d9999dfe8ca77d1ac901c9 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-13436-to-k210
# Create the PR body template
PR_BODY=$(gh pr view 13436 --json body --template 'Backport 304db100b382f0c1d1d9999dfe8ca77d1ac901c9 from #13436{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'chore: [k210] fix(gateway client): exit with nil pointer dereference panic when using ring mode' --body-file - --label 'size/XS' --label 'type/bug' --label 'backport' --base k210 --milestone k210 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-13436-to-k210
# Create a pull request where the `base` branch is `k210` and the `compare`/`head` branch is `backport-13436-to-k210`.
# Remove the local backport branch
git switch main
git branch -D backport-13436-to-k210 |
…er in ring mode (#13436) Fixes gateway client return with nil pointer panic when using ring mode for ruler service. `clients.dnsProvider` will only be init when using `simple mode` here: https://github.com/grafana/loki/blob/183406570411a5ad5ceaf32bf07451b8fce608c1/pkg/indexgateway/client.go#L184 Service like `ruler` using `ring mode` will run into panic `nil pointer reference` during restarting or exiting: (cherry picked from commit 304db10)
What this PR does / why we need it:
Fixes gateway client return with nil pointer panic when using ring mode for ruler service.
clients.dnsProvider
will only be init when usingsimple mode
here:loki/pkg/indexgateway/client.go
Line 184 in 1834065
Service like
ruler
usingring mode
will run into panicnil pointer reference
during restarting or exiting:Which issue(s) this PR fixes:
Fix #13437
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR