feat(exporter): include boolean values in limit exporter (#13466)

grafana · Jul 9, 2024 · 4220737 · 4220737
1 parent e08b4a7
commit 4220737
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/pkg/validation/exporter.go b/pkg/validation/exporter.go
@@ -56,6 +56,12 @@ func (oe *OverridesExporter) Collect(ch chan<- prometheus.Metric) {
 			return float64(val.Field(i).Uint()), true
 		case float64:
 			return val.Field(i).Float(), true
+		case bool:
+			v := 0.0
+			if val.Field(i).Bool() {
+				v = 1.0
+			}
+			return v, true
 		default:
 			return 0, false
 		}

diff --git a/pkg/validation/exporter_test.go b/pkg/validation/exporter_test.go
@@ -35,12 +35,13 @@ func TestOverridesExporter_noConfig(t *testing.T) {
 func TestOverridesExporter_withConfig(t *testing.T) {
 	tenantLimits := map[string]*Limits{
 		"tenant-a": {
-			MaxQueriersPerTenant: 5,
+			MaxQueriersPerTenant:  5,
+			BloomCompactorEnabled: true,
 		},
 	}
 	overrides, _ := NewOverrides(Limits{}, newMockTenantLimits(tenantLimits))
 	exporter := NewOverridesExporter(overrides)
 	count := testutil.CollectAndCount(exporter, "loki_overrides")
-	assert.Greater(t, count, 0)
+	assert.Equal(t, 2, count)
 	require.Greater(t, testutil.CollectAndCount(exporter, "loki_overrides_defaults"), 0)
 }