-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real time metrics #678
Real time metrics #678
Conversation
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 64.83% 64.67% -0.17%
==========================================
Files 101 101
Lines 8221 8229 +8
==========================================
- Hits 5330 5322 -8
- Misses 2549 2565 +16
Partials 342 342
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I consider this fully done for now, even though we probably should refactor things again when we implement the arrival-rate based executor or the different rampup/rampdown methods or the native k6 clustering 😄. I did some simple performance tests yesterday and did not notice any regressions (it seemed like there was even a very slight performance improvement), so this should work for now and allow us to have better aggregation until we improve the whole engine/executor/"runner" architecture. |
Currently the samples channel is not closed, but this change would save us from headaches if we decide to change that in the future
This fixes #614 and fixes (or at least helps with) #670
The refactoring is complete and I've fixed all of the old unit tests. I don't expect any issues, but I still want to write a few new tests that specifically check certain things in the new workflow, like metrics from
setup()
andteardown()
and the real-timeliness of the metrics pipeline. Still, this this should be stable enough for code review and testing, especially to check if there are improvements to the aggregation characteristics.