Top level await #4007
Merged
Top level await #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
oleiade and
joanlopez
and removed request for
a team
oleiade
previously approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Took it for a spin locally, and you have no idea how having the ability to do this:
import { open, SeekMode } from 'k6/experimental/fs'
const file = await open('package.json')
export default async function () {
// ...
}Makes me happy! Great job @mstoykov, thanks a lot for making this happen, much appreciated! 🙇🏻 🎉 🚀
olegbespalov
previously approved these changes
Oct 23, 2024
mstoykov
dismissed stale reviews from olegbespalov and oleiade
The base branch was changed.
mstoykov
force-pushed
the
top-level-await
branch
from
667e0c5
to
6e84cca
Compare
joanlopez
reviewed
Oct 25, 2024
joanlopez
previously approved these changes
Oct 25, 2024
Co-authored-by: Joan López de la Franca Beltran <[email protected]>
oleiade
approved these changes
Oct 28, 2024
olegbespalov
approved these changes
Oct 28, 2024
joanlopez
approved these changes
Oct 28, 2024
|
It's worth updating also examples (like |
|
@olegbespalov 👍🏻 I'm on it. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
top-level-await support
Why?
It is part of the specification and it is hepful if you have async APIs ... which k6 starts to get more and more off.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)