-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k6 new subcommand #3394
Add k6 new subcommand #3394
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3394 +/- ##
==========================================
+ Coverage 73.30% 73.35% +0.05%
==========================================
Files 260 261 +1
Lines 19687 19739 +52
==========================================
+ Hits 14432 14480 +48
Misses 4365 4365
- Partials 890 894 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @andrewslotin,
thanks for addressing it 🙇
8df8ede
to
d2b8200
Compare
48274dd
to
c55470e
Compare
@mstoykov @olegbespalov Adding you so you are aware of it, as I know there are different opinions on this command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left a few minor comments and one suggestion 👍
2dd3dee
to
0650325
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with most of the changes as I commented before I would prefer if we not include here the Cloud suggestion with the old option.
127bcf7
to
f50241d
Compare
Hey, spotted this by chance when I was skimming notification emails, and I was immediately confused by the PR title, specifically about what is being initialized by My 2c: having such a sub-command to is probably a good idea. Though I very rarely make use of such commands in other tools, I know other people find them useful. However, the |
I like the idea of @olegbespalov, @codebien, what are your thoughts on this? I’d be up for making necessary renamings. |
I don't have a strong opinion here, |
5471985
OK, there is one more edit: I've replaced the link to k6.io/docs with Grafana docs ones, since we're migrating our documentation there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion about the init
vs. new
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite happy with the final solution. Thanks for the effort. 🙇 @andrewslotin
Co-authored-by: Ivan <[email protected]>
Co-authored-by: Ivan <[email protected]>
87b8392
to
28c3403
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
What?
This PR adds a new subcommand to
k6
that creates a new test script file and populates it with a sample script similar to the one in Grafana Cloud k6 script editor.Why?
This subcommand reduces the amount of boilerplate code required to author a new script. Sample code provides new k6 users with instructions on how to run this test in Grafana Cloud and/or enable Browser API by pointing them to appropriate places in documentation.
Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Closes #3294