Build and publish browser-enabled Docker image #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3199 +/- ##
=======================================
Coverage 73.23% 73.23%
=======================================
Files 259 259
Lines 19889 19889
=======================================
Hits 14565 14565
+ Misses 4402 4401 -1
- Partials 922 923 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankur22
reviewed
Jul 17, 2023
ankur22
reviewed
Jul 17, 2023
ka3de
reviewed
Jul 17, 2023
andrewslotin
force-pushed
the
browser_enabled_image
branch
from
24ac4bf to
3923581
Compare
mstoykov
approved these changes
Jul 25, 2023
|
@mstoykov, my plan is to rebase and squash the fixup commits before merging. |
andrewslotin
force-pushed
the
browser_enabled_image
branch
from
3923581 to
a5fb29c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a stage to the Dockerfile that adds
chromiumto the Docker image and enables k6 Browser API. The new stage is used to build and publish images with-with-browserlabel suffix.The resulting image is fairly large (~220MB compressed compared to ~16MB without
chromiuminstalled), hence a separate label for those who want to opt-in to use Browser API.Why?
Currently there is no easy way to use Browser API when running k6 as a Docker container. This makes it difficult to run browser-based tests in CI, since users need to first launch browser process in a separate container, provide the CDP URL to the k6 container and conditionally use
browser.connect()instead ofbrowser.launch()in their test scripts.Checklist
Related PR(s)/Issue(s)
Closes #2914