-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests on Windows #2647
Merged
Merged
Fix tests on Windows #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na--
force-pushed
the
fix-windows-tests
branch
from
August 16, 2022 12:10
da8a97d
to
218b059
Compare
na--
changed the title
[WIP] trying to diagnose and fix windows tests
Fix tests on Windows
Aug 16, 2022
mstoykov
previously approved these changes
Aug 16, 2022
oleiade
previously approved these changes
Aug 16, 2022
olegbespalov
previously approved these changes
Aug 16, 2022
na--
dismissed stale reviews from olegbespalov, oleiade, and mstoykov
via
August 16, 2022 12:37
3608b85
mstoykov
previously approved these changes
Aug 16, 2022
oleiade
previously approved these changes
Aug 16, 2022
olegbespalov
previously approved these changes
Aug 16, 2022
na--
dismissed stale reviews from olegbespalov, oleiade, and mstoykov
via
August 16, 2022 12:56
b6c6240
na--
force-pushed
the
fix-windows-tests
branch
from
August 16, 2022 12:56
3608b85
to
b6c6240
Compare
oleiade
approved these changes
Aug 16, 2022
mstoykov
approved these changes
Aug 16, 2022
olegbespalov
approved these changes
Aug 16, 2022
Finally ✔️ 🎉 😌 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1719