fix: fix ws not support throw option

[fatelei]

What is the pr for ?

Fix issue #2247

Test

With throw = false

With throw = true

[CLAassistant]

All committers have signed the CLA.

[codebien]

Hi @fatelei, thanks for your contributon 🙏

Can you add some test coverage, please?

In any case, we plan to merge soon a new WebSocket API, this would be a breaking change. @mstoykov Does it make sense at this point considering the upcoming API?

[fatelei]

Hi @fatelei, thanks for your contributon 🙏

Can you add some test coverage, please?

In any case, we plan to merge soon a new WebSocket API, this would be a breaking change. @mstoykov Does it make sense at this point considering the upcoming API?

unit test has been added

[codecov-commenter]

Codecov Report

Merging #2616 (2ed46d6) into master (7f823f0) will decrease coverage by 0.17%.
The diff coverage is 70.16%.

❗ Current head 2ed46d6 differs from pull request most recent head 8535b00. Consider uploading reports for the commit 8535b00 to get more accurate results

@@            Coverage Diff             @@
##           master    #2616      +/-   ##
==========================================
- Coverage   75.59%   75.42%   -0.18%     
==========================================
  Files         202      205       +3     
  Lines       15992    16292     +300     
==========================================
+ Hits        12089    12288     +199     
- Misses       3151     3238      +87     
- Partials      752      766      +14     

Flag	Coverage Δ
ubuntu	75.23% <70.16%> (-0.17%)	⬇️
windows	75.05% <70.16%> (-0.24%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cloudapi/config.go	86.66% <ø> (ø)
cmd/cloud.go	13.40% <ø> (ø)
cmd/login_cloud.go	19.76% <0.00%> (ø)
cmd/login_influxdb.go	11.66% <0.00%> (ø)
cmd/ui.go	61.35% <ø> (ø)
errext/exit_code.go	100.00% <ø> (ø)
js/common/bridge.go	100.00% <ø> (ø)
js/common/interrupt_error.go	100.00% <ø> (+18.18%)	⬆️
js/modules/k6/grpc/client.go	78.39% <0.00%> (ø)
js/timeout_error.go	56.25% <ø> (ø)
... and 61 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521a282...8535b00. Read the comment docs.

[mstoykov]

Thanks for the PR @fatelei 🙇
I have left some comments - you will also need to fix your linters

@codebien as I mention the fuller fix for this will require for error codes to be moved around and is arguably a bigger change. Likely one too touchy and big for an outside contributor :(.

I don't think we will be removing this API any time soon so any fixes for it are welcome as long as they aren't overly complex and not actually all the useful. We will definitely prefer to push the newer API. But the old one is still used by people so we will need to support at least until we have actually released a stable version of the new one IMO.

[codebien]

@fatelei you can run in local make lint so you don't have to wait for a CI run.

[codebien]

LGTM

[mstoykov]

LGTM! Thanks for getting this through 🙇

[codebien]

Thanks @fatelei for the effort 🙏

[mstoykov]

I have marked this as "breaking change" as the default value for throw is false - so by default we will now not throw an exception while we previously would've.