Add HMAC support to Crypto module #256
Conversation
js/modules/k6/crypto/crypto.go
Outdated
| @@ -151,3 +152,38 @@ func (hasher *Hasher) Digest(outputEncoding string) string { | |||
|
|
|||
| return "" | |||
| } | |||
|
|
|||
| func (c Crypto) CreateHmac(ctx context.Context, algorithm string, key string) *Hasher { | |||
There was a problem hiding this comment.
I think this should be capitalized; createHMAC() rather than createHmac(). It would be inconsistent with hmac(), but I think that'll have to stay for consistency's sake...
js/modules/k6/crypto/crypto_test.go
Outdated
|
|
||
| rt.Set("crypto", common.Bind(rt, &Crypto{}, &ctx)) | ||
|
|
||
| t.Run("Valid", func(t *testing.T) { |
There was a problem hiding this comment.
Please add test cases for an invalid algorithm too, and use the testdata/t.Run() idiom to run hasher + wrapper tests for each supported algorithm: https://github.com/loadimpact/k6/blob/0092f27224b995c3bfd41a7b9cc756dfef8f6777/js/modules/k6/k6_test.go#L49
There was a problem hiding this comment.
I wrote a default case in createHmac method for invalid or not supported algorithms that throw an "Invalid algorithm error", and I added it to unit tests, I think createHash must have the same default case, because trying to update or digest on the hasher created will cause a runtime error with nil pointer dereference, because hasher.hash is never asigned.
|
Almost there! |
|
Just get that function name changed and I'll merge o7 |
|
I just changed it |
|
👍 |
Closes #231