Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang.org/x/* dependencies to the latest #2443

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Update golang.org/x/* dependencies to the latest #2443

merged 3 commits into from
Mar 17, 2022

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Mar 14, 2022 •
edited
Loading

Update the golang/x dependencies to the latest

Main issue: #2445

@olegbespalov olegbespalov self-assigned this Mar 14, 2022
@olegbespalov olegbespalov added maintenance dependencies Pull requests that update a dependency file labels Mar 14, 2022
@github-actions github-actions bot requested review from codebien and mstoykov March 14, 2022 16:13
@olegbespalov olegbespalov mentioned this pull request Mar 15, 2022
Closed
5 tasks
codebien
codebien previously approved these changes Mar 16, 2022
View reviewed changes
@mstoykov
Copy link
Contributor

Can you please redo the PR with running go mod tidy before go mod vendor on each commit instead of just once in the end.

In this way each commit will be self-sufficient.

@na-- na-- added this to the v0.38.0 milestone Mar 16, 2022
@olegbespalov olegbespalov force-pushed the chore/update-golang-x branch from 6e19b57 to 4f61250 Compare March 16, 2022 13:33
@olegbespalov olegbespalov requested a review from codebien March 16, 2022 13:35
@olegbespalov olegbespalov force-pushed the chore/update-golang-x branch from 4f61250 to b368e20 Compare March 16, 2022 15:27
@mstoykov
Copy link
Contributor

Why is x/crypto and x/net updated twice ?

@olegbespalov
Copy link
Contributor Author

@mstoykov It was before we decided to go with updates from the master, decided to keep to commits to have a chance to discard the latest (from master) if the decision turn to opposite

@mstoykov
Copy link
Contributor

Hmmm 🤔 I feel like if we decided to revert we will revert to the original version first and then move to a vendored one.

So in reality I think having only 3 commits is better WDYT?

@olegbespalov
Copy link
Contributor Author

I'm fine with 3 commits only, let me change this

@olegbespalov olegbespalov force-pushed the chore/update-golang-x branch from b368e20 to 07e1561 Compare March 16, 2022 16:03
@olegbespalov olegbespalov merged commit 816f984 into master Mar 17, 2022
@olegbespalov olegbespalov deleted the chore/update-golang-x branch March 17, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@mstoykov mstoykov mstoykov approved these changes

Assignees

@olegbespalov olegbespalov

Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging this pull request may close these issues.
4 participants
@olegbespalov @mstoykov @codebien @na--