Prevent goroutines getting blocked in js tests #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The predominant reason was the use of context.Background() for a context, which leads to a goroutine waiting on it ending, to block indefinitely. The other case were gRPC tests which did *not* close their connections.
mstoykov
force-pushed
the
fixStrandledGoroutines
branch
from
25477f3 to
3d2d2dc
Compare
|
These were find around #2228 (comment) and were mostly caught by paniccing when Line 652 in 5c14dae |
na--
approved these changes
Dec 3, 2021
olegbespalov
approved these changes
Dec 10, 2021
codebien
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
- I am not really certain if it won't be good idea to check this in the production code as well thinking
If this would happen in production then I expect to see a lot of stuff stuck then it should be easy to catch, so I'm not sure. Considering the numbers of VUs we have, I see it relevant if there is a case where it could happen just for some VUs. But I don't see/know that case.
|
@codebien I doubt we have a bug in the production code, I was wondering about guarding again the same regression in test code, but this also didn't catch some variants and no other test broke in the whole codebase so 🤷 Let's leave it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predominant reason was the use of context.Background() for a context, which leads to a goroutine waiting on it ending, to block indefinitely.
The other case were gRPC tests which did not close their connections.