Cleanup and handleSummaryResult() tests #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
previously approved these changes
Jan 15, 2021
|
You are very wise... 😅 ugh, I'll have to remember how to fix the windows fs tests now... |
na--
force-pushed
the
handle-summary-changes
branch
from
b504fdb to
070b159
Compare
imiric
reviewed
Jan 18, 2021
Closed
imiric
previously approved these changes
Jan 18, 2021
imiric
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few other things I wondered if I should fix in the current Go summary code, but at this point in time I'll probably just fix them in the upcoming JS replacement... For example, this code: https://github.com/loadimpact/k6/blob/c00a85bfea21d748f0f9d11fdbc326087f34c411/ui/summary.go#L91
Should be
i.e. that
StrWidth()function is completely broken... 🤦♂️ But this turns not to matter one bit, since almost all of the errors are by the same margin and mostly cancel out... 🤣 Not to mention that the Unicode normalization it tries to do might actually be worse than not doing anything at all: https://github.com/loadimpact/k6/blob/c00a85bfea21d748f0f9d11fdbc326087f34c411/ui/summary.go#L64-L65See this MDN article for a good explanation of the various normalization modes, and why
NFCorNFKC(or even doing nothing) might be better for our use case thanNFKD. On the other hand, not even they are sufficient, so maybe it doesn't really matter and everything in life is pointless: https://hsivonen.fi/string-length/ 😭 😅 🤣Anyway, I think this is the final summary-related PR before v0.30.0.