-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method to stop a running Engine #1355
Conversation
Codecov Report
@@ Coverage Diff @@
## new-schedulers #1355 +/- ##
==================================================
- Coverage 76.60% 76.59% -0.01%
==================================================
Files 160 160
Lines 12567 12584 +17
==================================================
+ Hits 9627 9639 +12
- Misses 2431 2436 +5
Partials 509 509
Continue to review full report at Codecov.
|
@hynd, to fix these linter issues locally, take a look at the "Running the linter" section in https://github.com/loadimpact/k6/blob/master/CONTRIBUTING.md#development-setup Also, I realize that a |
31afae9
to
439788c
Compare
Understood - the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
df03d0e
to
15d1edd
Compare
Thanks! |
Including a new
stop
cmd to trigger it via the HTTP API.Closes #1352.