Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run windows tests with -race #903

Open
mstoykov opened this issue Jan 21, 2019 · 2 comments
Open

Run windows tests with -race #903

mstoykov opened this issue Jan 21, 2019 · 2 comments

Comments

@mstoykov
Copy link
Contributor

Because of a recent issue -race needs CGO which needs gcc under windows :( .
We should still be able to run our test with -race even if that mean that we need to install gcc.

@vanshaj
Copy link
Contributor

vanshaj commented Jul 4, 2022

Hello @mstoykov and @na--
As per the discussion in the mentioned golang issue, there is a flag -vet which we can turn off to resolve this problem.
Kindly read comment for the fix or do we need to create a document on how to setup gcc so that we can add it here and help the community members.
kindly update me on the fix which you think is optimal and assign the issue so that I can start working on the same.

Regards
Vanshaj Dhar

@mstoykov
Copy link
Contributor Author

mstoykov commented Jul 6, 2022

@vanshaj there is no need for you to be assigned on an issue in order to work and make PRs.

I am going to assign you this time, but you can just open PRs especially for small PRs.

For larger - it is probably better to at least mention in the issue you are working on it, but unless it looks like we are working on it - we likely aren't :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants