Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename stuff #1425

Closed
na-- opened this issue Apr 30, 2020 · 4 comments
Closed

Rename stuff #1425

na-- opened this issue Apr 30, 2020 · 4 comments

Comments

@na--
Copy link
Member

na-- commented Apr 30, 2020

As suggested by @robingustafsson and @sniku, it would be better if we rename execution to scenarios in the global config and type to executor in the individual executor/scenario config.

Some executor names could also be improved:

  • variable-looping-vus => ramping-vus
  • constant-looping-vus => constant-vus
  • variable-arrival-rate => ramping-arrival-rate
  • constant-arrival-rate => constant-arrival-rate

(though I'm not sure if ramping is the best choice here... variable or dynamic aren't bad, as in dynamic-vus?)

So, the config from #1007 should look somewhat like this:

export let options = {
  scenarios: {
    stages_up_down: {
      executor: "ramping-vus",
      startVUs: 0,
      stages: [
        { duration: "10s", target: 20 },
        { duration: "10s", target: 0 },
      ],
      gracefulRampDown: "0s",
      gracefulStop: "0s",
    },
    const_loop_vus: {
      executor: "constant-vus",
      vus: 20,
      duration: "20s",
      gracefulStop: "0s",
    },
    constant_arr_rate: {
      executor: "constant-arrival-rate",
      rate: 20,
      timeUnit: "1s",
      duration: "10s",
      preAllocatedVUs: 10,
      maxVUs: 20,
      startTime: "20s",
      gracefulStop: "0s",
    },
    variable_arr_rate: {
      executor: "ramping-arrival-rate",
      startRate: 20,
      timeUnit: "1s",
      preAllocatedVUs: 10,
      maxVUs: 20,
      startTime: "20s",
      stages: [
        { target: 0, duration: "5s" },
        { target: 20, duration: "5s" },
      ],
      gracefulStop: "0s",
    },
    per_vu_iters: {
      executor: "per-vu-iterations",
      vus: 20,
      iterations: 10,
      startTime: "30s",
      maxDuration: "10s",
      gracefulStop: "10s",
    },
    shared_iters: {
      executor: "shared-iterations",
      vus: 20,
      iterations: 200,
      startTime: "30s",
      maxDuration: "10s",
      gracefulStop: "10s",
    },
    adjustable_at_will: {
      executor: "externally-controlled",
      vus: 5,
      maxVUs: 10,
      duration: "40s",
    },
  },
};
@na-- na-- added this to the v0.27.0 milestone Apr 30, 2020
@na--
Copy link
Member Author

na-- commented Apr 30, 2020

Also, this renaming should probably happen in tandem with #1302

@sniku
Copy link
Collaborator

sniku commented Apr 30, 2020

While you are renaming the executors, please also make this change:
image

It might also be worth to grep for "Insights" in the codebase.

@mstoykov
Copy link
Contributor

mstoykov commented Apr 30, 2020

rg Insights .
./SUPPORT.md
12:If your questions are about any of the commercial Load Impact services like managed cloud execution and Load Impact Insights, you can contact <[email protected]> or write in the `#loadimpact` channel in [Slack](https://k6.io/slack).

./release notes/v0.21.0.md
70:**Docs**: [Load Impact Insights Aggregation](https://docs.k6.io/docs/load-impact-insights#section-aggregation)

./release notes/v0.20.0.md
230:* Cloud/Insights: Fixed issue causing default test name to be empty when parsing script from STDIN (#510)
232:* Cloud/Insights: Fixed handling of unexpected responses from server. (#522)

./release notes/v0.23.1.md
5:* Cloud: Fixed the interaction between the environment variable and JSON-based configuration, and the Load Impact specific `env.loadimpact` JS options. Now only the `projectID`, `name` and `token` fields will be populated (without overriding other fields) when executing scripts with `k6 cloud`, and taken into account when sending metrics to Load Impact Insights with `k6 run -o cloud`. (#848, #871, #872)

./release notes/v0.23.0.md
102:A new option that disables the end-of-test summary has been added. That summary is often superfluous when k6 tests are run in a distributed execution mode, or when the generated metrics are piped to an external output like InfluxDB or Load Impact Insights. The option can be enabled with the `--no-summary` CLI flag or the `K6_NO_SUMMARY` environment variable. When both it and the and the `--no-thresholds` option are enabled, k6 won't store any generated metrics in-memory, making the test execution a bit more efficient.

./stats/cloud/collector.go
129: return nil, errors.New("Tests with unspecified duration are not allowed when using Load Impact Insights")

./597493/loadimpact/loadimpact.js
66: // Record time to first byte and tag it with the URL to be able to filter the results in Insights

@na-- na-- self-assigned this May 21, 2020
na-- added a commit that referenced this issue Jun 9, 2020
This handles the executor configuration parts of #1425, without actually changing the Go type names or structure yet.
na-- added a commit that referenced this issue Jun 9, 2020
This handles the executor configuration parts of #1425, without actually changing the Go type names or structure yet.
@na--
Copy link
Member Author

na-- commented Jun 9, 2020

Resolved by #1497

@na-- na-- closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants