fixup! js/k6/exec: Allow to set state's Tags

grafana · Nov 2, 2021 · aaf5192 · aaf5192
1 parent 9ac20d7
commit aaf5192
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/js/modules/k6/execution/execution.go b/js/modules/k6/execution/execution.go
@@ -234,9 +234,11 @@ func (o *tagsDynamicObject) Get(key string) goja.Value {
 	return o.Runtime.ToValue(tag)
 }
 
-// Set a property value for the key. Return true if succeed.
-// If a type different from a string is passed as value then
-// it will be implicitly converted to the goja's relative string representation.
+// Set a property value for the key. It returns true if succeed.
+// String, Boolean and Number types are implicitly converted
+// to the goja's relative string representation.
+// In any other case, if the Throw option is set then an error is raised
+// otherwise just a Warning is written.
 func (o *tagsDynamicObject) Set(key string, val goja.Value) bool {
 	switch val.ExportType().Kind() { //nolint:exhaustive
 	case