Ensure s3 requests send a null body when unset #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
force-pushed
the
fix-s3-requests-null-bodies
branch
from
c4bfb05 to
9284a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was experimenting and debugging around #50, I tracked down one of the main issues to be true that the request bodies were wrongly handled when unset.
Great catch @w0rd-driven 👏🏻
This Pull Request now ensures S3 requests without a body are passed to k6 with their body set to
null.In the experimentations I've made with DigitalOcean spaces, it seems to have fixed most of the issues I was encountering.