Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Protocol from Hardcoded 'https' to Dynamic Scheme #51

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Modify Protocol from Hardcoded 'https' to Dynamic Scheme #51

merged 1 commit into from
Jun 20, 2023

Conversation

NPJigaK
Copy link
Contributor

@NPJigaK NPJigaK commented Jun 18, 2023 •
edited
Loading

fix #49

I have tried to check the operation in my local environment.
In addition, I checked other Client classes and found that scheme can be set.

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@NPJigaK
Copy link
Contributor Author

NPJigaK commented Jun 18, 2023

@mstoykov Please review.

mstoykov
mstoykov approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@mstoykov mstoykov merged commit 7f41b86 into grafana:main Jun 20, 2023
@NPJigaK NPJigaK deleted the patch-1 branch June 20, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify Protocol from Hardcoded 'https' to Dynamic Scheme
3 participants
@NPJigaK @CLAassistant @mstoykov