Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for jslib http-instrumentation-pyroscope #1554

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Add docs for jslib http-instrumentation-pyroscope #1554

merged 6 commits into from
Apr 30, 2024

Conversation

mstoykov
Copy link
Contributor

What?

Add docs for a new jslib

See grafana/jslib.k6.io#118

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

mpandurovic
mpandurovic reviewed Apr 19, 2024
View reviewed changes
docs/sources/next/javascript-api/jslib/http-instrumentation-pyroscope/_index.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/jslib/http-instrumentation-pyroscope/_index.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/jslib/http-instrumentation-pyroscope/_index.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/jslib/http-instrumentation-pyroscope/_index.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/jslib/http-instrumentation-pyroscope/client.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/jslib/http-instrumentation-pyroscope/client.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/jslib/http-instrumentation-pyroscope/client.md Outdated Show resolved Hide resolved
@mstoykov @knylander-grafana @mpandurovic
Apply suggestions from code review
fca5272 
Co-authored-by: Kim Nylander <[email protected]>
Co-authored-by: Marko Pandurovic <[email protected]>
knylander-grafana
knylander-grafana approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with one small change for the page header. Thank you for adding documentation!

@mstoykov mstoykov merged commit 579bb94 into main Apr 30, 2024
5 checks passed
@mstoykov mstoykov deleted the httpInstrumentationPyroscopeDocs branch April 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knylander-grafana knylander-grafana knylander-grafana approved these changes

@heitortsergent heitortsergent Awaiting requested review from heitortsergent heitortsergent is a code owner

@Rperry2174 Rperry2174 Awaiting requested review from Rperry2174

@mpandurovic mpandurovic Awaiting requested review from mpandurovic

Assignees
No one assigned
Labels
type/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mstoykov @heitortsergent @mpandurovic @knylander-grafana