-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k6chaijs 4.5.0.0 - dropping need for 'global' alias #136
Conversation
supported.json
Outdated
@@ -41,7 +41,7 @@ | |||
"docs-url": "https://k6.io/docs/javascript-api/jslib/expect" | |||
}, | |||
"k6chaijs": { | |||
"versions": ["4.3.4.0", "4.3.4.1", "4.3.4.2", "4.3.4.3"], | |||
"versions": ["4.3.4.0", "4.3.4.1", "4.3.4.2", "4.3.4.3", "4.5.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"versions": ["4.3.4.0", "4.3.4.1", "4.3.4.2", "4.3.4.3", "4.5.0"], | |
"versions": ["4.3.4.0", "4.3.4.1", "4.3.4.2", "4.3.4.3", "4.5.0.0"], |
lib/index.html
Outdated
@@ -612,7 +612,7 @@ <h2>Available libs</h2> | |||
<td><a href="https://k6.io/docs/javascript-api/jslib/expect">https://k6.io/docs/javascript-api/jslib/expect</a></td> | |||
</tr><tr> | |||
<td>k6chaijs</td> | |||
<td><a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.0/index.js">4.3.4.0</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.1/index.js">4.3.4.1</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.2/index.js">4.3.4.2</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.3/index.js">4.3.4.3</a></td> | |||
<td><a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.0/index.js">4.3.4.0</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.1/index.js">4.3.4.1</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.2/index.js">4.3.4.2</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.3/index.js">4.3.4.3</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.5.0/index.js">4.5.0</a></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td><a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.0/index.js">4.3.4.0</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.1/index.js">4.3.4.1</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.2/index.js">4.3.4.2</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.3/index.js">4.3.4.3</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.5.0/index.js">4.5.0</a></td> | |
<td><a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.0/index.js">4.3.4.0</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.1/index.js">4.3.4.1</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.2/index.js">4.3.4.2</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.3.4.3/index.js">4.3.4.3</a>, <a target="_blank" href="https://jslib.k6.io/k6chaijs/4.5.0.0/index.js">4.5.0.0</a></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is an inconsistency in the version format, sometimes it is referred as 4.5.0
while sometimes it is as 4.5.0.0
, and beyond possible confusion that may cause, I think the import/links won't work if they aren't consistent among them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on @joanlopez comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Description
Update to latest version of k6chaijs
Please fill in this template.
npm run test
command succeeds.yarn run generate-homepage
locally and verify the new homepage/lib/index.html
file looks legit.Select one of these and delete the others:
If adding a new jslib:
/lib/{jslib_name}
folder./lib/{jslib_name}/{desired_version}
folder./lib/{jslib_name}/{desired_version}/index.js
file containing the jslib's code bundle exists.supported.json
file to contain an entry for the newly added jslib and its{desired_version}
, as in the following example:/tests/basic.js
and/tests/testSuite.js
to ensure that the added jslib is importable and runnable by k6.If publishing a new version of an existing jslib:
version bump
label./lib/{jslib_name}/{desired_version}
folder./lib/{jslib_name}/{desired_version}/index.js
file containing the jslib's code bundle.supported.json
file to contain an entry for the newly added jslib version, as in the following example:/tests/basic.js
and/tests/testSuite.js
files to ensure that the new version of the jslib is importable and runnable by k6.