fix: removed unsupported time ordering from interpolated query; cache… #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chejimmy
requested review from
idastambuk and
kevinwcyu
and removed request for
a team
chejimmy
force-pushed
the
fix-time-order
branch
2 times, most recently
from
e303457 to
5072066
Compare
… id of aggregates
idastambuk
approved these changes
Jun 13, 2024
sarahzinger
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
One stylistic suggestion, but I'm also ok with us doing this at another time.
Ran the e2e tests in a separate draft: #324 and it all passed. Going to merge.
| @@ -83,6 +79,44 @@ export class QualityAndOrderRow extends PureComponent<Props> { | |||
| onChange({ ...query, maxPageAggregations: +event.currentTarget.value }); | |||
| }; | |||
|
|
|||
| timeOrderField = () => { | |||
There was a problem hiding this comment.
if we want to break this into it's own function, I think it might make sense to create a separate functional component for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… id of aggregates
What this PR does / why we need it:
Which issue(s) this PR fixes:
aggregates