fix: asset property list render #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracy-french
requested review from
iwysiu and
njvrzm
and removed request for
a team
kevinwcyu
approved these changes
Feb 29, 2024
|
Thanks for the fix @tracy-french, I'll have a look at #285 next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: #279 included a change which caused the asset property drop-down to not render the asset property names. This is due to a reference to the wrong list, which was not caught by TypeScript, as the
optionsprop of<Select />does not have strong type safety (i.e., it only requires a list of typeT).#285 acts as an effective regression test to ensure asset property list is functional.