Fetch asset property info if assetId and propertyId are available #192
Conversation
kevinwcyu
requested review from
fridgepoet and
sarahzinger
and removed request for
a team
|
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors |
| @@ -28,7 +28,7 @@ func (rp *SitewiseResources) Asset(ctx context.Context, assetId string) (*iotsit | |||
| } | |||
|
|
|||
| func (rp *SitewiseResources) Property(ctx context.Context, assetId string, propertyId string, propertyAlias string) (*iotsitewise.DescribeAssetPropertyOutput, error) { | |||
| if propertyAlias != "" { | |||
| if propertyAlias != "" && (assetId == "" && propertyId == "") { | |||
There was a problem hiding this comment.
Silly question maybe, but is it a given that if assetId != "" that propertyId != "" and visa-versa?
There was a problem hiding this comment.
yea, an asset property is identified by either an alias or (asset id and property id).
Extracted from this PR https://github.com/grafana/iot-sitewise-datasource/pull/190/files#r1197884481
Update
Propertymethod inpkg/resource/sitewise.goso it will callDescribeAssetPropertyWithContextas long as an asset id and property id is available. Previously, it would not callDescribeAssetPropertyWithContextifpropertyAliaswas not an empty string, but now that we get the asset id and property id from the alias, we can callDescribeAssetPropertyWithContext. You can see the test output files now have the asset name and property names in them e.g. "Demo Turbine Asset 1" and "Average Wind Speed".