Replace deprecated setVariableQueryEditor with CustomVariableSupport #184
Conversation
fridgepoet
changed the title
|
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors |
|
Backend code coverage report for PR #184 |
|
Frontend code coverage report for PR #184
|
|
Glad to hear it's working! I haven't manually tested but took a look at the code and I believe this basically matches what we've done in the past, seems like a good approach to me! |
fridgepoet
requested review from
iwysiu and
idastambuk
and removed request for
a team
What this PR does / why we need it:
This replaces the deprecated
setVariableQueryEditorwithCustomVariableSupportmodeled after what is used in the Athena datasource.Which issue(s) this PR fixes:
Fixes #154
Special notes for your reviewer:
I made an attempt to updated the deprecated setVariableQueryEditor. If I'm not mistaken in the build, I think it's working! I modeled it off of what is done in Athena.
Any suggestions are very welcome!
Here's the video of the change:
https://github.com/grafana/iot-sitewise-datasource/assets/4163034/40debff9-1617-499e-8622-3e56e79f142b
Now the regex filters by the name of the values for the regex.