Update Storybook updates to v6.5.10 #49793
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
area/frontend
dependencies
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/20167 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/20263 |
jackw
force-pushed
the
renovate/storybook-updates
branch
from
41adc6d to
dc1819a
Compare
jackw
force-pushed
the
renovate/storybook-updates
branch
from
dc1819a to
0806286
Compare
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/28938 |
jackw
added
no-backport
jackw
changed the title
jackw
force-pushed
the
renovate/storybook-updates
branch
from
4a769c3 to
446ceae
Compare
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/31603 |
|
This upgrade is currently blocked by: hipstersmoothie/storybook-dark-mode/pull/187 |
jackw
requested review from
a team,
joshhunt,
JoaoSilvaGrafana,
mdvictor and
supilee
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/35566 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/35606 |
| @@ -0,0 +1,49 @@ | |||
| { | |||
There was a problem hiding this comment.
only thing that makes me a little queasy is this is a large amount of custom babel settings, buuuuuut i'm assuming there's no way round it? 😅
There was a problem hiding this comment.
Yeah, I'm not too keen on it either. I was hoping the storybook default babelrc would handle things but without this storybook cannot compile grafana/ui. Throws lots of errors related to not understanding typescript?!
If you have already enabled that plugin (or '@babel/preset-typescript'), make sure that it runs before any plugin related to additional class features:
- @babel/plugin-proposal-class-properties
- @babel/plugin-proposal-private-methods
- @babel/plugin-proposal-decorators
57 | implements OptionsFormat
58 | {
> 59 | declare readonly onlyIn: (node: Node) => boolean;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
60 | declare readonly getSyntax: (node: Node) => string;
61 | declare readonly renderDecoration: (
62 | {
Let me have a dabble and see if I can figure out a better approach. 😄
There was a problem hiding this comment.
@ashharrison90 please see f55d927
There was a problem hiding this comment.
@jackw anything that says turbo-build sounds good to me 😂
There was a problem hiding this comment.
Shame it broke the build of core. I'll fix it up shortly.
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/35693 |
…l compile without error
|
Leaving this here for future reference (renovate bot deletes any updates I make to PR description). I took over this PR as updating storybook to 6.5.x was more convoluted that originally expected. Actual changes in this PR:
|
This PR contains the following updates:
6.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.126.4.21->6.5.12Configuration
📅 Schedule: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.