Admin: Fixes close('X') button layout issue in API keys page #27625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikasvan
requested review from
a team,
hugohaggmark and
peterholmberg
and removed request for
a team
nikasvan
changed the title
|
looks like we have a snapshot test, you can update it with `just -u ApiKeys" and checking the updated snapshot! Thanks for fixing this! ❤️ |
torkelo
approved these changes
Sep 16, 2020
hugohaggmark
approved these changes
Sep 17, 2020
hugohaggmark
pushed a commit
that referenced
this pull request
Sep 17, 2020
* ApiKeys: Fixes add API key layout * ApiKeys: snapshot tests updated (cherry picked from commit 5a06ed4)
This was referenced Sep 17, 2020
hugohaggmark
pushed a commit
that referenced
this pull request
Sep 17, 2020
* ApiKeys: Fixes add API key layout * ApiKeys: snapshot tests updated (cherry picked from commit 5a06ed4)
marefr
changed the title
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
* ApiKeys: Fixes add API key layout * ApiKeys: snapshot tests updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the form layout issue. Close button was breaking the layout.
Which issue(s) this PR fixes:
#27322