Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Scroll issue in dashboard search in latest Chrome #17054

Merged
merged 1 commit into from
May 14, 2019

Conversation

jschill
Copy link
Contributor

@jschill jschill commented May 14, 2019

What this PR does / why we need it:
Mobile users with latest Chrome are not able to scroll in dashboard search.

Which issue(s) this PR fixes:
Fixes #16981

Special notes for your reviewer:
Confirmed working in chrome 74 on osx and chrome 74 on android.

@torkelo torkelo changed the title Fix: Scroll issue in dashboard search in latest Chrome DashbordSearch: Scroll issue in dashboard search in latest Chrome May 14, 2019
@torkelo torkelo changed the title DashbordSearch: Scroll issue in dashboard search in latest Chrome Search: Scroll issue in dashboard search in latest Chrome May 14, 2019
@torkelo torkelo merged commit ceb21bd into master May 14, 2019
@torkelo torkelo deleted the 16981-scroll-dashboard-search-chrome branch May 14, 2019 09:08
@torkelo torkelo added this to the 6.2.0 milestone May 14, 2019
ryantxu added a commit to ryantxu/grafana that referenced this pull request May 14, 2019
* grafana/master:
  Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064)
  serverlock: run tests async should be more linear time wise (grafana#17059)
  InfoPopover: Fixes transclude undefined error (grafana#17063)
  Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055)
  fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057)
  Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974)
  Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054)
  Docs: adds note about removing session storage (grafana#17003)
  Chore: remove use of `== false` (grafana#17036)
  Explore: use @grafana/ui legend (grafana#17027)
  tech: avoid alias for importing models in alerting (grafana#17041)
  DataSourcePlugin: support custom tabs (grafana#16859)
  Dashboard: Fixes scrolling issues for Edge browser (grafana#17033)
  SeriesData: remove color from Field (grafana#17044)
ryantxu added a commit to ryantxu/grafana that referenced this pull request May 14, 2019
* grafana/master:
  Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064)
  serverlock: run tests async should be more linear time wise (grafana#17059)
  InfoPopover: Fixes transclude undefined error (grafana#17063)
  Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055)
  fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057)
  Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974)
  Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054)
  Docs: adds note about removing session storage (grafana#17003)
  Chore: remove use of `== false` (grafana#17036)
  Explore: use @grafana/ui legend (grafana#17027)
  tech: avoid alias for importing models in alerting (grafana#17041)
  DataSourcePlugin: support custom tabs (grafana#16859)
  Dashboard: Fixes scrolling issues for Edge browser (grafana#17033)
  SeriesData: remove color from Field (grafana#17044)
ryantxu added a commit to ryantxu/grafana that referenced this pull request May 14, 2019
…-grafanaui

* grafana/master:
  Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064)
  serverlock: run tests async should be more linear time wise (grafana#17059)
  InfoPopover: Fixes transclude undefined error (grafana#17063)
  Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055)
  fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057)
  Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974)
  Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054)
  Docs: adds note about removing session storage (grafana#17003)
  Chore: remove use of `== false` (grafana#17036)
  Explore: use @grafana/ui legend (grafana#17027)
  tech: avoid alias for importing models in alerting (grafana#17041)
  DataSourcePlugin: support custom tabs (grafana#16859)
  Dashboard: Fixes scrolling issues for Edge browser (grafana#17033)
  SeriesData: remove color from Field (grafana#17044)
ryantxu added a commit to ryantxu/grafana that referenced this pull request May 14, 2019
* grafana/master: (33 commits)
  Panels: Fixed alert icon position in panel header (grafana#17070)
  GraphPanel: use SeriesData directly (skip legacy transformation) (grafana#17037)
  Streaming: support streaming in MetricsPanelCtrl (grafana#17034)
  Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064)
  serverlock: run tests async should be more linear time wise (grafana#17059)
  InfoPopover: Fixes transclude undefined error (grafana#17063)
  Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055)
  fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057)
  Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974)
  Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054)
  Docs: adds note about removing session storage (grafana#17003)
  Chore: remove use of `== false` (grafana#17036)
  Explore: use @grafana/ui legend (grafana#17027)
  tech: avoid alias for importing models in alerting (grafana#17041)
  DataSourcePlugin: support custom tabs (grafana#16859)
  Dashboard: Fixes scrolling issues for Edge browser (grafana#17033)
  SeriesData: remove color from Field (grafana#17044)
  chore: remove x character in explore
  Dashboard: show refresh button in kiosk mode (grafana#17032)
  Devenv: Updated gauge test dashboard
  ...
torkelo pushed a commit that referenced this pull request May 15, 2019
ryantxu added a commit to NatelEnergy/grafana that referenced this pull request May 15, 2019
* grafana/master: (25 commits)
  Chore: Bump jest to 24.8.0 (grafana#17094)
  Chore: Bump ts-node to 8.1.0 (grafana#17093)
  Release: Updated changelog
  backend: replace /pkg/errors with errutil (grafana#17065)
  Explore: Fixes filtering in Prometheus queries when clicking in Table (grafana#17083)
  Remotecache: Avoid race condition in Set causing error on insert.  (grafana#17082)
  Build: Support publishing MSI to grafana.com (grafana#17073)
  InputDataSource: better empty value support (grafana#17075)
  Panels: Fixed alert icon position in panel header (grafana#17070)
  GraphPanel: use SeriesData directly (skip legacy transformation) (grafana#17037)
  Streaming: support streaming in MetricsPanelCtrl (grafana#17034)
  Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064)
  serverlock: run tests async should be more linear time wise (grafana#17059)
  InfoPopover: Fixes transclude undefined error (grafana#17063)
  Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055)
  fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057)
  Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974)
  Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054)
  Docs: adds note about removing session storage (grafana#17003)
  Chore: remove use of `== false` (grafana#17036)
  ...
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: impossible to scroll over the dashboards list on mobile
3 participants