(prometheus) get label name/value from series API #12251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtanda
force-pushed
the
prometheus_use_matchers_for_completion
branch
5 times, most recently
from
2d9622c to
4bc735c
Compare
davkal
requested changes
Jul 26, 2018
mtanda
force-pushed
the
prometheus_use_matchers_for_completion
branch
from
37741e1 to
1f3c39f
Compare
|
Okay, I change the code :-) |
davkal
reviewed
Jul 26, 2018
| return this.datasource.performInstantQuery({ expr: query }, new Date().getTime() / 1000).then(response => { | ||
| this.labelQueryCache[expr] = response.data.data.result; | ||
| return response.data.data.result; | ||
| let range = this.datasource.getTimeRange(); |
There was a problem hiding this comment.
Should be const { start, end } = this.datasource.getTimeRange();
Also, url below should be const.
Should I add types like |
|
The types are good as is now. Thank you. Could please rebase? Then we can merge. |
mtanda
force-pushed
the
prometheus_use_matchers_for_completion
branch
from
5202c16 to
bf88402
Compare
|
rebased. |
davkal
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instant query doesn't return all label name/value of dashboard time range.
So, change to use series API.
https://prometheus.io/docs/prometheus/latest/querying/api/#finding-series-by-label-matchers