Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace racially charged language "whitelist/blacklist" #18841

Closed
naomijub opened this issue Sep 2, 2019 · 7 comments
Closed

Replace racially charged language "whitelist/blacklist" #18841

naomijub opened this issue Sep 2, 2019 · 7 comments
Labels
area/backend/config stale Issue with no recent activity

Comments

@naomijub
Copy link

naomijub commented Sep 2, 2019 •
edited
Loading

What would you like to be added:
I'd like to deprecate the "whitelist/blacklist" language in Grafana, replacing them with "safelist/blocklist" or "allowlist/denylist" (This has been done in many places like Graphite )

Why is this needed:
This is important to help Grafana become more inclusive.
@torkelo
Copy link
Member

torkelo commented Sep 3, 2019

Ah, good feedback! never thought about the origin of these words!

@daniellee
Copy link
Contributor

daniellee commented Sep 17, 2019 •
edited
Loading

We don't have any blacklists except for tslints rules - as that is an external lib that would be hard to change. Unless I am missing something?

We use whitelist in three places:

@stale
Copy link

stale bot commented Dec 2, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue with no recent activity label Dec 2, 2019
@naomijub
Copy link
Author

naomijub commented Dec 2, 2019

@daniellee The idea is to replace any references to whitelist to something like allowlist and blacklist to something like denylist. So data_source_proxy_whitelist would become data_source_proxy_allowlist and in the Azure Monito:

Azure Monitor Metrics Allowlist
Not all metrics returned by the Azure Monitor API have values. The Grafana data source has a allowlist to only return metric names if it is possible they might have values. This allowlist is updated regularly as new services and metrics are added to the Azure cloud. You can find the current allowlist here.

I can open an issue in Tslint as well for their blacklist

@stale stale bot removed the stale Issue with no recent activity label Dec 2, 2019
timneutkens added a commit to timneutkens/next.js that referenced this issue Jun 2, 2020
@timneutkens
Use inclusive naming for variables / examples
1b38658 
The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FILE_NAME_WHITELIST

Prior discussions on this topic:
- hashicorp/consul#7901
- styled-system/styled-system#391
- go-sql-driver/mysql#1116
- lagom/lagom#2532
- grafana/grafana#18841
@timneutkens timneutkens mentioned this issue Jun 2, 2020
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this issue Jun 2, 2020
@timneutkens
Use inclusive naming for variables / examples (#13657)
31b3e46 
https://twitter.com/vercel/status/1267650234236252161

The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FILE_NAME_WHITELIST

Prior discussions on this topic:
- hashicorp/consul#7901
- styled-system/styled-system#391
- go-sql-driver/mysql#1116
- lagom/lagom#2532
- grafana/grafana#18841
@marcusolsson marcusolsson mentioned this issue Jun 11, 2020
Merged
daniellee added a commit that referenced this issue Jun 11, 2020
@daniellee
docs: remove racially charged words
bac0e46 
ref #18841
@daniellee daniellee mentioned this issue Jun 11, 2020
Merged
daniellee added a commit that referenced this issue Jun 11, 2020
@daniellee
docs: remove racially charged words (#25535)
1e88e50 
ref #18841
@kylebrandt
Copy link
Contributor

Also the auth proxy https://grafana.com/docs/grafana/latest/auth/auth-proxy/

aknuds1 pushed a commit that referenced this issue Jun 30, 2020
@daniellee @aknuds1
docs: remove racially charged words (#25535)
a98fb29 
ref #18841
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
@timneutkens @rokinsky
Use inclusive naming for variables / examples (vercel#13657)
35dc709 
https://twitter.com/vercel/status/1267650234236252161

The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FILE_NAME_WHITELIST

Prior discussions on this topic:
- hashicorp/consul#7901
- styled-system/styled-system#391
- go-sql-driver/mysql#1116
- lagom/lagom#2532
- grafana/grafana#18841
@naomijub naomijub mentioned this issue Jul 1, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last year. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Jan 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically closed because it has not had any further activity in the last 30 days. Thank you for your contributions!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/backend/config stale Issue with no recent activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@torkelo @daniellee @kylebrandt @naomijub