Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links from alerts to panels are broken #15454

Closed
bergquist opened this issue Feb 15, 2019 · 0 comments · Fixed by #15455
Closed

Links from alerts to panels are broken #15454

bergquist opened this issue Feb 15, 2019 · 0 comments · Fixed by #15455
Labels
area/alerting Grafana Alerting prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
6.0-beta3

Comments

@bergquist
Copy link
Contributor

Links generated by the alerting backend does not work as expected.

Ex http://localhost:3000/d/000000006/prometheus-alerting?fullscreen=true&edit=true&tab=alert&panelId=1&orgId=1&refresh=10s This used to focus the panel the alert tab in the panel with the alert.

Right now it just renders the full dashboard.
@bergquist bergquist added prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/alerting Grafana Alerting labels Feb 15, 2019
@bergquist bergquist added this to the 6.0-beta3 milestone Feb 15, 2019
torkelo added a commit that referenced this issue Feb 15, 2019
@torkelo
fixed handling of alert urls with true flags, fixes #15454
7699706
@torkelo torkelo mentioned this issue Feb 15, 2019
Merged
ryantxu added a commit to ryantxu/grafana that referenced this issue Feb 16, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into panel-in-view-from…
53ef092 
…-scroll

* grafana/master:
  docs: suggested changes
  docs: fix header
  fixed handling of alert urls with true flags, fixes grafana#15454
  Fixed dashboard navbar buttons being visible in fullscreen, fixes grafana#15450
  Added missing strict type checking options to grafana/ui and fixed type errors
  Extracted common code for diff calculation
  fix spelling error
  whats new: rename security section
  Fix percent_diff calculation when points are nulls
  docs: move alerting above session
  docs: mention samesite setting
  docs: adds note about new login cookie name
  docs: improve removal of session storage for what's new in v6.0
  docs: add upgrade notes for v6.0
  docs: add note regarding auth proxy and user session requirement
  docs: fix typo
ryantxu added a commit to ryantxu/grafana that referenced this issue Feb 16, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into dynamic-height-panels
445fb0a 
* grafana/master:
  docs: suggested changes
  docs: fix header
  fixed handling of alert urls with true flags, fixes grafana#15454
  Fixed dashboard navbar buttons being visible in fullscreen, fixes grafana#15450
  Added missing strict type checking options to grafana/ui and fixed type errors
  Extracted common code for diff calculation
  fix spelling error
  whats new: rename security section
  Fix percent_diff calculation when points are nulls
  docs: move alerting above session
  docs: mention samesite setting
  docs: adds note about new login cookie name
  docs: improve removal of session storage for what's new in v6.0
  docs: add upgrade notes for v6.0
  docs: add note regarding auth proxy and user session requirement
  docs: fix typo
ryantxu added a commit to ryantxu/grafana that referenced this issue Feb 16, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into jwt
ff72521 
* grafana/master:
  docs: suggested changes
  docs: fix header
  fixed handling of alert urls with true flags, fixes grafana#15454
  Fixed dashboard navbar buttons being visible in fullscreen, fixes grafana#15450
  Added missing strict type checking options to grafana/ui and fixed type errors
  Extracted common code for diff calculation
  fix spelling error
  whats new: rename security section
  Fix percent_diff calculation when points are nulls
  docs: move alerting above session
  docs: mention samesite setting
  docs: adds note about new login cookie name
  docs: improve removal of session storage for what's new in v6.0
  docs: add upgrade notes for v6.0
  docs: add note regarding auth proxy and user session requirement
  docs: fix typo
xlson pushed a commit that referenced this issue Feb 18, 2019
@torkelo @xlson
fixed handling of alert urls with true flags, fixes #15454
acb329f 
(cherry picked from commit 7699706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/alerting Grafana Alerting prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
6.0-beta3
Development

Successfully merging a pull request may close this issue.

Fixed handling of alert urls with true flags grafana/grafana
1 participant
@bergquist