Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add dashboards with long names to playlist #13464

Closed
neufeldtech opened this issue Sep 28, 2018 · 2 comments · Fixed by #13548
Closed

Cannot add dashboards with long names to playlist #13464

neufeldtech opened this issue Sep 28, 2018 · 2 comments · Fixed by #13548
Labels
beginner friendly effort/small help wanted type/bug type/ux
Milestone
5.3.1

Comments

@neufeldtech
Copy link
Contributor

neufeldtech commented Sep 28, 2018 •
edited
Loading

What Grafana version are you using?

v5.2.4

What OS are you running grafana on?

Linux (CentOS)

What did you do?

On /playlists/create page, I'm attempting to add a dashboard that has a long name to a playlist

What was the expected result?

The 'Add to playlist' button should be clickable, and we should be able to add a dashboard to the playlist.

What happened instead?

The 'Add to playlist' button is not clickable when dashboards with long names are present in the current filter.

image
@torkelo
Copy link
Member

torkelo commented Oct 4, 2018

think this can be fixed using css only. setting some max width, text overflow elipsis

@neufeldtech
Copy link
Contributor Author

neufeldtech commented Oct 5, 2018 •
edited
Loading

I'll take a crack at this, even though CSS is terrifying 👻

neufeldtech added a commit to neufeldtech/grafana that referenced this issue Oct 6, 2018
@neufeldtech
Fix text overflow on playlist search grafana#13464
4815f92
@neufeldtech neufeldtech mentioned this issue Oct 6, 2018
Merged
@torkelo torkelo added this to the 5.4 milestone Oct 6, 2018
torkelo added a commit that referenced this issue Oct 6, 2018
@torkelo
Merge pull request #13548 from neufeldtech/playlist_fix
b411e8e 
Fix text overflow on playlist search  #13464
@marefr marefr modified the milestones: 5.4, 5.3.1 Oct 15, 2018
marefr added a commit that referenced this issue Oct 15, 2018
@marefr
changelog: add notes about closing #13464
f4b7b00 
[skip ci]
marefr pushed a commit that referenced this issue Oct 15, 2018
@neufeldtech @marefr
Fix text overflow on playlist search #13464
22880a7 
(cherry picked from commit 4815f92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly effort/small help wanted type/bug type/ux
Projects
None yet
Milestone
5.3.1
Development

Successfully merging a pull request may close this issue.

Fix text overflow on playlist search #13464 neufeldtech/grafana
3 participants
@torkelo @marefr @neufeldtech