Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Team Admin role that can only can edit its own team. #11584

Closed
drt-infor opened this issue Apr 13, 2018 · 2 comments · Fixed by #15977
Closed

Add Team Admin role that can only can edit its own team. #11584

drt-infor opened this issue Apr 13, 2018 · 2 comments · Fixed by #15977

Comments

@drt-infor
Copy link

drt-infor commented Apr 13, 2018

We would like to have the ability to designate a member(s) in a given Team as a "Team Admin" so that they could self-manage the ability to add/remove users to/from their Team.

We are currently running Grafana 5.0.3 in Docker containers on Linux.

@drt-infor drt-infor changed the title Would like to have a Team Admin capability [Feature Request] Would like to have a Team Admin capability Apr 13, 2018
@bergquist bergquist changed the title [Feature Request] Would like to have a Team Admin capability Add Team Admin role that can only can edit its own team. Apr 16, 2018
@paulsson
Copy link

I would really like to see this implemented. It would remove the need for the Org admin(s) to manage users for all Teams within the Org.
It would be best if this were a permission at the Team level vs the Org level.
ie. If I am an "admin" for 2 out of 5 Teams, I can only manage users for those 2 Teams.

idavidmcdonald pushed a commit to alphagov/reliability-engineering that referenced this issue Sep 4, 2018
- It is rare that teams are using the GDS default dashboard because
they are now creating their own dashboards and using those
- We also have other sources of metrics meaning teams may also
use the container metrics dashboard or metrics for tools like
elasticsearch.

Based on this I have:

- Added a short explanation for how team folders are organised
- Added definitions of the purpose of the dashboards in the
General folder
- Moved the detailed explanation of the default application dashboard
into it's own page (but have made no content changes)
- Removed some of the simpler content as I don't think we have seen
evidence of users struggling to use Grafana so far

Note: I have kept the section on team dashboard permissions brief
and vague - essentially contact us for help - as I think we need
to do more on team permissions. At the moment, teams will not
be able to manage the permissions for users of their team without
having admin privileges of the whole system as per
grafana/grafana#11584. This may be something
we want to investigate further to avoid us needing to manage all
user permissions in terms of which teams they can access and instead
being able to put this burden on the teams themselves.
@yijingping
Copy link

@drt-infor @paulsson I have finished this feature on this pull request: #13144 , and waiting to be merged.

idavidmcdonald pushed a commit to alphagov/reliability-engineering that referenced this issue Sep 11, 2018
- It is rare that teams are using the GDS default dashboard because
they are now creating their own dashboards and using those
- We also have other sources of metrics meaning teams may also
use the container metrics dashboard or metrics for tools like
elasticsearch.

Based on this I have:

- Added a short explanation for how team folders are organised
- Added definitions of the purpose of the dashboards in the
General folder
- Moved the detailed explanation of the default application dashboard
into it's own page (but have made no content changes)
- Removed some of the simpler content as I don't think we have seen
evidence of users struggling to use Grafana so far

Note: I have kept the section on team dashboard permissions brief
and vague - essentially contact us for help - as I think we need
to do more on team permissions. At the moment, teams will not
be able to manage the permissions for users of their team without
having admin privileges of the whole system as per
grafana/grafana#11584. This may be something
we want to investigate further to avoid us needing to manage all
user permissions in terms of which teams they can access and instead
being able to put this burden on the teams themselves.
@xlson xlson self-assigned this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants