Skip to content

Commit

Permalink
Toolkit: Deprecate node-version-check command (#57591)
Browse files Browse the repository at this point in the history
* Toolkit: Deprecate node-version-check command

* Do not check for nodejs version on frontend-test
  • Loading branch information
academo authored Oct 25, 2022
1 parent f64b0e1 commit 8d42e1b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"typecheck": "tsc --noEmit && yarn run packages:typecheck",
"plugins:build-bundled": "grafana-toolkit plugin:bundle-managed",
"watch": "yarn start -d watch,start core:start --watchTheme",
"ci:test-frontend": "yarn run test:ci && yarn grafana-toolkit node-version-check",
"ci:test-frontend": "yarn run test:ci",
"postinstall": "husky install",
"i18n:clean": "rimraf public/locales/en-US/grafana.json",
"i18n:extract": "yarn i18n:clean && yarn run i18next -c public/locales/i18next-parser.config.js 'public/**/*.{tsx,ts}' 'packages/grafana-ui/**/*.{tsx,ts}' && node ./public/locales/psuedo.js",
Expand Down
11 changes: 9 additions & 2 deletions packages/grafana-toolkit/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,15 @@ export const run = (includeInternalScripts = false) => {

program
.command('node-version-check')
.description('Verify node version')
.action(async (cmd) => {
.description('[deprecated] Verify node version')
.action(async () => {
chalk.yellow.bold(
`⚠️ This command is deprecated and will be removed in v10. No further support will be provided. ⚠️`
);
console.log(
'if you were reliant on this command we recommend https://www.npmjs.com/package/check-node-version'
);

await execTask(nodeVersionCheckerTask)({});
});

Expand Down

0 comments on commit 8d42e1b

Please sign in to comment.