fix event severity change #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderzobnin
requested changes
Jan 15, 2020
|
|
||
| let severityDesc: TriggerSeverity; | ||
| severityDesc = _.find(panelOptions.triggerSeverity, s => s.priority === Number(problem.priority)); | ||
| if (problem.lastEvent.severity) { |
There was a problem hiding this comment.
It's better to check if lastEvent not empty also:
Suggested change
| if (problem.lastEvent.severity) { | |
| if (problem.lastEvent && problem.lastEvent.severity) { |
|
|
||
| let severityDesc: TriggerSeverity; | ||
| severityDesc = _.find(problemSeverityDesc, s => s.priority === Number(props.original.priority)); | ||
| if (problem.lastEvent.severity) { |
There was a problem hiding this comment.
The same as above.
| @@ -398,7 +398,12 @@ export class TriggerPanelCtrl extends PanelCtrl { | |||
|
|
|||
| // Filter triggers by severity | |||
| triggerList = _.filter(triggerList, trigger => { | |||
| return this.panel.triggerSeverity[trigger.priority].show; | |||
| //return this.panel.triggerSeverity[trigger.priority].show; | |||
| if (trigger.lastEvent.severity) { | |||
There was a problem hiding this comment.
The same
Suggested change
| if (trigger.lastEvent.severity) { | |
| if (trigger.lastEvent && trigger.lastEvent.severity) { |
| @@ -398,7 +398,12 @@ export class TriggerPanelCtrl extends PanelCtrl { | |||
|
|
|||
| // Filter triggers by severity | |||
| triggerList = _.filter(triggerList, trigger => { | |||
| return this.panel.triggerSeverity[trigger.priority].show; | |||
| //return this.panel.triggerSeverity[trigger.priority].show; | |||
There was a problem hiding this comment.
Could be removed
Suggested change
| //return this.panel.triggerSeverity[trigger.priority].show; |
alexanderzobnin
approved these changes
Jan 16, 2020
|
@memfiz could you fix comments above? |
Fixed. |
|
@memfiz I mean |
|
Yes, my fault. Another try... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #870.
Not sure about the code style. It works in my production, but I'm not an expert in typescript/javascript.