Backend: implement alerting query(Part 1) #819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vignesh-reddy
changed the title
vignesh-reddy
changed the title
alecxvs
reviewed
Oct 11, 2019
| return groups, nil | ||
| } | ||
|
|
||
| func (ds *ZabbixDatasource) getAllItems(ctx context.Context, dsInfo *datasource.DatasourceInfo, hostids []string, appids []string, itemtype string) (*simplejson.Json, error) { |
There was a problem hiding this comment.
Is "getAllItems" a good name for this? It's not really getting all items, usually it's filtered by hostids.
|
Any estimate on reviewing the backend PRs? |
alecxvs
approved these changes
Nov 26, 2019
|
Closing this PR, will open a new one with an initial alerting feature in a working state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #801
Implemented part of the alerting query issue to get data from Zabbix and parse the query by fetching groups, hosts, apps, and items.
Initially parsed the query to get the filters for groups, hosts, apps, and items and later fetched the data from the Zabbix data source for all groups, hosts, apps, and items and filtered those bypassing them into regex filter.