fixes for scenes framework #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yesoreyeram
commented
Apr 22, 2024
•
yesoreyeram
commented
- Fixes Plugin is failing to render in new Scenes architecture #1819
- Also update backend plugin SDK
gabor
reviewed
Apr 22, 2024
| return getHash(argsJson); | ||
| } catch (ex) { | ||
| console.error(`failing to get the request hash for caching. type of args ${typeof args}`); | ||
| return 0; |
There was a problem hiding this comment.
i wonder if it would be safer to return Math.random() or something similar here, because 0 will cause every such request to share the cache-key... WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.