Implement data processing functions on the backend #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily closes #869 and adds full support of alerting for metric queries (including data processing functions). It also contains fixes for another issues such as #1221, #1239, #1233 and #1252.
The trickiest part here is maintaining compatibility of the direct DB connection feature, since queries to other data sources only available on the frontend currently. So if this feature enabled, plugin invokes query to the database from the frontend (using existing SQL data source) and then sends data to the special backend endpoint for the processing (applying functions). I treat this as a workaround and going to move DB queries to the backend in future versions.
The only functions applying on the frontend now is alias functions and timeShift (in some types of queries).