Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable image #8

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Configurable image #8

merged 2 commits into from
Apr 24, 2019

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Apr 24, 2019

Make the Grafana Image and Tag configurable using command line args.

Verification:

  1. Create an empty namespace using grafana
  2. Run the operator locally using operator-sdk up local --namespace=grafana --operator-flags "--grafana-image registry.redhat.io/openshift3/grafana --grafana-image-tag v3.11"
  3. Deploy a grafana instance to this namespace using oc create -f deploy/examples/Grafana.yaml
  4. Wait until everything is deployed.
  5. Inspect the Grafana deployment and make sure it is using the specified Red Hat image.
  6. Delete the Grafana CR and restart the operator without the extra flags
  7. Deploy another Grafana instance
  8. Make sure that this time it is using the public community Grafana image.

@pb82 pb82 requested a review from davidkirwan April 24, 2019 10:47
@davidkirwan
Copy link
Contributor

image

After removing the Grafana CR and restarting the operator without the custom flags

image2

Copy link
Contributor

@davidkirwan davidkirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pb82 pb82 merged commit c1b4237 into grafana:master Apr 24, 2019
@pb82 pb82 deleted the configurable-image branch April 24, 2019 11:43
@pb82 pb82 mentioned this pull request Apr 25, 2019
@david-martin david-martin mentioned this pull request Apr 30, 2019
9 tasks
@david-martin
Copy link
Contributor

@pb82 @davidkirwan I'm interested in your thoughts on changing how the custom image is specified.
The approach in this PR looks reasonable, however it has a couple of limitations.

The prometheus operator allows the base image to be specified in the CR here: https://github.com/coreos/prometheus-operator/blob/master/pkg/apis/monitoring/v1/types.go#L104-L105.
What are your thoughts on moving to a similar approach for specifying the Grafana image to use?

kd7lxl referenced this pull request in kd7lxl/grafana-operator Mar 11, 2021
changed hash calculation algorithm to trigger dashboard reconciling on
env value changing
hubeadmin added a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants