fix datasource json and secure json fields #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
The problem was that grafana uses a type of
map[string]interface{}
for the jsonData and secureJsonData fields of a data source. The operator-sdk does not support code generation forinterface{}
fields. Instead of only allowing strings we're now providing structs for the most common jsonData and secureJsonData options as documented here.Verification steps:
quay.io/integreatly/grafana-operator:fix-extra-json
tag.tlsSkipVerify
option should be checked.