feat: add user agent to requests made by operator #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a user agent which includes the operator version to all requests made by the operator. By doing this, Grafana administrators can better differentiate between requests that originated from humans and those performed by the operator
theSuess
requested review from
NissesSenap,
weisdd,
ishanjainn and
pb82
as code owners
weisdd
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
The only catch about .Git.Tag is that it doesn't point at a particular commit, but rather indicates the last tag found in git tree. It's not a problem at all, I was just curious what would happen if I try to make a build from a non-tagged commit.
User-Agent seems to work well, and I absolutely agree that it's a useful change.
LGTM :)
|
@weisdd it will fall back to the latest tag present locally. Shouldn't be an issue though since we always build from tags in the release pipeline |
Baarsgaard
added a commit
to Baarsgaard/grafana-operator
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a user agent which includes the operator version to all requests made by the operator. By doing this, Grafana administrators can better differentiate between requests that originated from humans and those performed by the operator