Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply duration validation to all resync periods #1505

Merged
merged 5 commits into from
Apr 29, 2024
Merged

fix: apply duration validation to all resync periods #1505

merged 5 commits into from
Apr 29, 2024

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Apr 23, 2024

fixes #1483

adds validation to all ResyncPeriod fields. It can only be a valid Go duration string and it defauts to 5m.

@NissesSenap
Copy link
Collaborator

@pb82 you need to update your kubebuilder version locally.
Easiest is just to remove the bin folder, and it will automatically download a new version.

weisdd
weisdd approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@weisdd weisdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pb82 I've regenerated manifests with kubebuilder v0.14.0 and tested the validation, everything seems to be fine, I think we should be good to merge the PR.

@pb82
Copy link
Collaborator Author

pb82 commented Apr 23, 2024

thanks @weisdd !

@pb82
Copy link
Collaborator Author

pb82 commented Apr 23, 2024

@weisdd kustomize crds are not yet updated, let me fix this

@weisdd
Copy link
Collaborator

weisdd commented Apr 23, 2024

@pb82 LGTM

@weisdd
Copy link
Collaborator

weisdd commented Apr 23, 2024 •
edited
Loading

@pb82 I created a PR that supplements yours: #1506, so let's merge it to your branch (if the changes look right), and then yours - to master.

weisdd and others added 2 commits April 27, 2024 06:21
@weisdd
fix(api-docs): generate CRDs for api-docs and add missing reference t…
d2e1403 
…o grafanacontactpoints (#1506)

* fix(makefile): generate CRDs with descriptions to be later used for api-docs

* fix(kustomization): add grafanacontactpoints to the kustomization used for api-docs

* fix(crds, api-docs): generate CRDs and api-docs
@NissesSenap
Merge branch 'master' into fix-1483
c609650
@NissesSenap NissesSenap merged commit 0fc62ab into master Apr 29, 2024
10 checks passed
@NissesSenap NissesSenap deleted the fix-1483 branch April 29, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weisdd weisdd weisdd approved these changes

@theSuess theSuess theSuess approved these changes

@NissesSenap NissesSenap Awaiting requested review from NissesSenap NissesSenap is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of extended validation for resyncPeriod
4 participants
@pb82 @NissesSenap @weisdd @theSuess