Value breakdowns: Update UI #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
…2/drilldown-values-ui-updates
matyax
reviewed
Dec 10, 2024
matyax
reviewed
Dec 10, 2024
src/Components/ServiceScene/Breakdowns/ClearFiltersLayoutScene.tsx
Outdated
Show resolved
Hide resolved
matyax
reviewed
Dec 10, 2024
| export interface ClearFiltersLayoutSceneState extends SceneObjectState { | ||
| clearCallback: () => void; | ||
| } | ||
| export class ClearFiltersLayoutScene extends SceneObjectBase<ClearFiltersLayoutSceneState> { |
There was a problem hiding this comment.
We could also make the message configurable and reuse here https://github.com/grafana/grafana/blob/main/public/app/features/trails/Breakdown/ByFrameRepeater.tsx#L163
There was a problem hiding this comment.
A bit confused, are you proposing we move this to core?
matyax
reviewed
Dec 10, 2024
src/Components/ServiceScene/Breakdowns/FieldsBreakdownScene.tsx
Outdated
Show resolved
Hide resolved
matyax
reviewed
Dec 10, 2024
matyax
reviewed
Dec 10, 2024
src/Components/ServiceScene/Breakdowns/LabelValuesBreakdownScene.tsx
Outdated
Show resolved
Hide resolved
matyax
reviewed
Dec 10, 2024
matyax
reviewed
Dec 10, 2024
matyax
reviewed
Dec 10, 2024
matyax
reviewed
Dec 10, 2024
gtk-grafana
deleted the
gtk-grafana/issues/862/drilldown-values-ui-updates
branch
shantanualsi
pushed a commit
that referenced
this pull request
Dec 17, 2024
* feat: rearrange menus and add new single "summary" panel above value breakdowns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #862
Adds "summary" time series above value breakdowns for visual differentiation of value breakdowns from label breakdowns.
Collapsed:
Want to look into moving the field/label name selector into the panel header
