Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
concurrency.ForEachJob()
#113concurrency.ForEachJob()
#113Changes from all commits
3f61fb4
0f6aeb7
1d3748e
5b0be33
6faae52
a491840
2934349
a19cdad
133a232
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly does this test checks as opposed to
TestForEachJob_ShouldBreakOnFirstError_ContextCancellationHandled
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see,
TestForEachJob_ShouldBreakOnFirstError_ContextCancellationHandled
is a simple test that returns an error and makes sure that context is canceled, without extra assertions on how many jobs were launched.This
TestForEachJob_ShouldBreakOnFirstError_ContextCancellationUnhandled
makes sure that when two jobs (with concurrency=2) are launched, then the third job is not launched at all.