Use custom type as context key.

grafana · Oct 6, 2023 · 9d8eea6 · 9d8eea6
1 parent 7082799
commit 9d8eea6
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/server/limits_test.go b/server/limits_test.go
@@ -291,8 +291,11 @@ type methodLimiter struct {
 	protectedMethodInflight      atomic.Int64
 }
 
+type ctxKey string
+
 const (
-	ctxMethodName    = "method"
+	ctxMethodName ctxKey = "method"
+
 	metaAbortRequest = "abort-request"
 )
 
@@ -322,8 +325,8 @@ func (m *methodLimiter) RPCCallStarting(ctx context.Context, methodName string,
 func (m *methodLimiter) RPCCallFinished(ctx context.Context) {
 	m.allInflight.Dec()
 
-	methodName := ctx.Value(ctxMethodName).(string)
-	if methodName == m.protectedMethod && m.protectedMethodInflightLimit > 0 {
+	methodName := ctx.Value(ctxMethodName).(ctxKey)
+	if string(methodName) == m.protectedMethod && m.protectedMethodInflightLimit > 0 {
 		m.protectedMethodInflight.Dec()
 	}
 }