fix(rules): upstream recording rule switched to sum_irate #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
commented
Aug 25, 2021
| @@ -213,7 +213,7 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |||
| sum by (cluster, namespace, deployment) ( | |||
| label_replace( | |||
| label_replace( | |||
| node_namespace_pod_container:container_cpu_usage_seconds_total:sum_rate, | |||
| node_namespace_pod_container:container_cpu_usage_seconds_total:sum_irate, | |||
There was a problem hiding this comment.
I'm not sure if we should reflect that in the name of this recording rule too (line 211).
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…ix_cpu_irate fix(rules): upstream recording rule switched to sum_irate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: kubernetes-monitoring/kubernetes-mixin#619
What this PR does:
Upstream recording rule switched to sum_irate, this was reflected in the recording rule name.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]