Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ruler alerts, and add playbooks. #347

Merged
merged 8 commits into from
Jul 2, 2021
Merged

Replace ruler alerts, and add playbooks. #347

merged 8 commits into from
Jul 2, 2021

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Jul 2, 2021

What this PR does: This PR replaces CortexRulerFailedEvaluations alert with two new alerts: CortexRulerTooManyFailedPushes and CortexRulerTooManyFailedQueries. Note that second alert is only marked as "warning" for now, until cortexproject/cortex#4333 is fixed.

This PR also adds playbooks for these two alerts.

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pstibrany pstibrany requested a review from a team as a code owner July 2, 2021 12:15
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just one minor thing to fix.

cortex-mixin/alerts/alerts.libsonnet Outdated Show resolved Hide resolved
@pstibrany
Copy link
Member Author

I've addressed your feedback. PTAL.

@pracucci pracucci merged commit fe7bd13 into main Jul 2, 2021
@pracucci pracucci deleted the ruler-alerts branch July 2, 2021 13:31
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants