Replaced CortexCacheRequestErrors with CortexMemcachedRequestErrors #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Jul 2, 2021
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…or-CortexCacheRequestErrors Replaced CortexCacheRequestErrors with CortexMemcachedRequestErrors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
I found out that
CortexCacheRequestErrorsdoesn't work because the instrumentation code never track errors (any cache request is tracked as a success):Also, if you're running the blocks storage, this alert is only on query-frontend cache client, cause for all other caching is based on Thanos memcached cache.
For this reason, in this PR I've replaced
CortexCacheRequestErrorsalert (not working) withCortexMemcachedRequestErrors.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]