Fix empty values generated for maps and arrays in go #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the diff show code changes that would be introduced by this PR to the Foundation SDK. Changes already on
grafana-foundation-sdk@next+cog-v0.0.x |
spinillos
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #653
Builders sometimes need to perform initializations with empty values before performing the "main" assignment(s).
See https://github.com/grafana/grafana-foundation-sdk/blob/2f6cab6e04b60c66f3bf4314f83e16fe5c8a06fa/go/timeseries/panel_builder_gen.go#L490
This PR ensures that we generate correct empty values for arrays and maps (we don't actually have a schema that needs those... yet: dashboards v2 will).